Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trait bounds to config: Index: Default, BlockNumber: AtLeast32BitsUnsigned #648

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Add trait bounds to config: Index: Default, BlockNumber: AtLeast32BitsUnsigned #648

merged 3 commits into from
Sep 25, 2023

Conversation

clangenb
Copy link
Collaborator

@clangenb clangenb commented Sep 15, 2023 •
edited
Loading

Seems like reasonable assumptions for me, and they made my code in the worker a bit more ergonomic. :)

@clangenb clangenb changed the title Add trait bounds to Config: Index: Default, BlockNumber; AtLeast32BitsUnsigned Add trait bounds to Config: Index: Default, BlockNumber: AtLeast32BitsUnsigned Sep 15, 2023
@clangenb clangenb requested a review from masapr September 15, 2023 08:24
@clangenb clangenb changed the title Add trait bounds to Config: Index: Default, BlockNumber: AtLeast32BitsUnsigned Add trait bounds to config: Index: Default, BlockNumber: AtLeast32BitsUnsigned Sep 15, 2023
haerdib
haerdib approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me. Thanks for helping out!

@clangenb clangenb merged commit dc012e4 into master Sep 25, 2023
40 checks passed
@haerdib haerdib added the F7-enhancement Enhances an already existing functionality label Nov 9, 2023
@haerdib haerdib deleted the cl/add-more-trait-bounds-to-config branch February 5, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haerdib haerdib haerdib approved these changes

@masapr masapr Awaiting requested review from masapr

Assignees
No one assigned
Labels
E1-breaksnothing F7-enhancement Enhances an already existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config::Index type should have default trait bound
2 participants
@clangenb @haerdib